-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: serialize changedFiles passed to workers #8090
Conversation
183cd48
to
43e2e3c
Compare
@@ -86,7 +86,10 @@ export async function worker({ | |||
globalConfig, | |||
config, | |||
getResolver(config, moduleMap), | |||
context, | |||
context && { | |||
...config, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
context
not config
, no?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yea, how did that passed typecheck :o
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think config
is a superset of context
Is there a date on when is this going to be released? Not being able to |
Hopefully today |
I updated to 24.4.0 and am still having the issue described in #8084 and #8088.
|
Could you put together a reproduction? |
Same repo as #8088 https://github.com/arb/celebrate/tree/feature-ref That branch, |
@arb it's a problem you your package manager. Try yarn or at least remove Jest references from Running:
works just fine. |
@thymikee removed all of The (currently) two 👍on #8090 (comment) makes me think there are others who have tried the new version and are having the same problem even after the update. Are there any suggestions for how I can help resolve this issue? |
We have upgraded and it's working fine for us. Many thanks @SimenB !! |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
Serialize Set to Array in coverage and test workers.
Fixes #8084.
Test plan
@SimenB feel free to add a test, I need to run away from my computer at the moment.